Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44011: New asyncio ssl implementation #31275

Merged
merged 3 commits into from Feb 15, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Feb 11, 2022

kumaraditya303 and others added 3 commits Feb 11, 2022
Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Feb 11, 2022

@sobolevn Test with buildbots. Thanks

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022
@bedevere-bot
Copy link

bedevere-bot commented Feb 11, 2022

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 10db2f2 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022
@asvetlov
Copy link
Contributor

asvetlov commented Feb 11, 2022

Thanks for picking this work up!

@kumaraditya303 kumaraditya303 marked this pull request as ready for review Feb 11, 2022
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Feb 11, 2022

cc @asvetlov The build-bots passed and are all green, ready for merge!

@asvetlov asvetlov added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022
@bedevere-bot
Copy link

bedevere-bot commented Feb 13, 2022

🤖 New build scheduled with the buildbot fleet by @asvetlov for commit 10db2f2 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022
Copy link
Contributor

@asvetlov asvetlov left a comment

Looks good.
I've scheduled yet another buildbots round to make sure.

Also, please document the new ssh_shutdown_timeout

@bedevere-bot
Copy link

bedevere-bot commented Feb 13, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Feb 14, 2022

@asvetlov I am busy currently so I suggest to land this and I'll prepare a PR for docs shortly.

@kumaraditya303 kumaraditya303 requested a review from asvetlov Feb 14, 2022
@sobolevn
Copy link
Member

sobolevn commented Feb 14, 2022

This failure looks related: https://buildbot.python.org/all/#/builders/178/builds/435

@asvetlov
Copy link
Contributor

asvetlov commented Feb 14, 2022

@sobolevn why do you think so?
I read the following summary as everything is almost fine, test_concurrent_futures alters the environment.
The concurrent futures are not affected by this PR, I read this error as unrelated.

1 test altered the execution environment:
    test_concurrent_futures
14 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_nis
    test_readline test_startfile test_tix test_tk test_ttk_guionly
    test_winconsoleio test_winreg test_winsound test_zipfile64
1 re-run test:
    test_unittest
    ```

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Feb 14, 2022

It is clearly unrelated.

Copy link
Contributor

@asvetlov asvetlov left a comment

Ok, lgtm

@asvetlov asvetlov merged commit 13c10bf into python:main Feb 15, 2022
85 of 86 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Feb 15, 2022

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@kumaraditya303 kumaraditya303 deleted the asyncio-ssl branch Mar 4, 2022
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Mar 10, 2022
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
JelleZijlstra pushed a commit that referenced this pull request Mar 10, 2022
GH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, GH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
ambv added a commit to ambv/cpython that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants