New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44011: New asyncio ssl implementation #31275
Conversation
Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>
@sobolevn Test with buildbots. Thanks |
Thanks for picking this work up! |
cc @asvetlov The build-bots passed and are all green, ready for merge! |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@asvetlov I am busy currently so I suggest to land this and I'll prepare a PR for docs shortly. |
This failure looks related: https://buildbot.python.org/all/#/builders/178/builds/435 |
@sobolevn why do you think so?
|
It is clearly unrelated. |
@asvetlov: Please replace |
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
GH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, GH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
This reverts commit 13c10bf.
Co-Authored-By: Andrew Svetlov andrew.svetlov@gmail.com
https://bugs.python.org/issue44011