bpo-41354: Adjust filecmp.cmp() to match documentation #21580
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This change needs a unit test and a news entry. |
| if shallow and s1 == s2: | ||
| return True | ||
| if s1[1] != s2[1]: | ||
| if s1 != s2: |
There was a problem hiding this comment.
It seems like if mtime is different but otherwise files are the same, current code will return True but this PR will change it to return False. That both breaks backwards compatibility and doesn't seem right to me.
|
Closing in favor of GH-27166. |
https://bugs.python.org/issue41354