Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89653: PEP 670: Convert pycore_gc.h macros to functions #92649

Merged
merged 2 commits into from May 11, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 11, 2022

Convert the following macros to static inline functions:

  • _Py_AS_GC()
  • _PyGCHead_FINALIZED(), _PyGCHead_SET_FINALIZED()
  • _PyGCHead_NEXT(), _PyGCHead_SET_NEXT()
  • _PyGCHead_PREV(), _PyGCHead_SET_PREV()
  • _PyGC_FINALIZED(), _PyGC_SET_FINALIZED()
  • _PyObject_GC_IS_TRACKED()
  • _PyObject_GC_MAY_BE_TRACKED()

Add a macro wrapping the _PyObject_GC_IS_TRACKED() function to cast
the argument to PyObject*.

Convert the following macros to static inline functions:

* _Py_AS_GC()
* _PyGCHead_FINALIZED(), _PyGCHead_SET_FINALIZED()
* _PyGCHead_NEXT(), _PyGCHead_SET_NEXT()
* _PyGCHead_PREV(), _PyGCHead_SET_PREV()
* _PyGC_FINALIZED(), _PyGC_SET_FINALIZED()
* _PyObject_GC_IS_TRACKED()
* _PyObject_GC_MAY_BE_TRACKED()

Add a macro wrapping the _PyObject_GC_IS_TRACKED() function to cast
the argument to PyObject*.
@vstinner
Copy link
Member Author

vstinner commented May 11, 2022

cc @erlend-aasland

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Looks good to me

@vstinner vstinner merged commit ffcc7cd into python:main May 11, 2022
12 checks passed
@vstinner vstinner deleted the pycore_gc_macros branch May 11, 2022
@vstinner
Copy link
Member Author

vstinner commented May 11, 2022

Merged, thanks for the review @erlend-aasland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants