Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90994: Improve error messages upon call arguments syntax errors #96893

Merged
merged 2 commits into from Nov 20, 2022
Merged

gh-90994: Improve error messages upon call arguments syntax errors #96893

merged 2 commits into from Nov 20, 2022

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Sep 17, 2022 •
edited by miss-islington

Automerge-Triggered-By: GH:pablogsal

@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner Sep 17, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 20, 2022
Open
@lysnikolaou
Copy link
Contributor Author

lysnikolaou commented Nov 20, 2022

@pablogsal friendly ping.

@pablogsal
Copy link
Member

pablogsal commented Nov 20, 2022

I am terribly sorry for the delay @lysnikolaou. Somehow this has fly under my radar :(

@pablogsal pablogsal force-pushed the gh90994-call-error-messages branch from 5e9f6a3 to b2286f0 Compare Nov 20, 2022
@pablogsal
Copy link
Member

pablogsal commented Nov 20, 2022

@lysnikolaou I have fixed for you a conflict in Parser/parser.c (I have rebased this PR)

pablogsal
pablogsal approved these changes Nov 20, 2022
View changes
Copy link
Member

@pablogsal pablogsal left a comment

🚀 Excellent work!

@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 20, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 20, 2022

@lysnikolaou: Status check is done, and it's a failure or timed out ❌.

@lysnikolaou
Copy link
Contributor Author

lysnikolaou commented Nov 20, 2022

Thanks for the review @pablogsal! Merging this by hand since Azure pipelines failed.

@lysnikolaou lysnikolaou merged commit 6d8da23 into python:main Nov 20, 2022
14 of 15 checks passed
@lysnikolaou lysnikolaou removed the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysnikolaou @pablogsal @miss-islington @bedevere-bot