gh-100221: Fix creating dirs in make sharedinstall
#100329
Open
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix creating install directories in
make sharedinstall
if they exist already outsideDESTDIR
. The previous make rules assumed that the directories would be created via a dependency on a rule for$(DESTSHARED)
that did not fire if the directory did exist outside$(DESTDIR)
.While technically
$(DESTDIR)
could be prepended to the rule name, moving the rules for creating directories straight into thesharedinstall
rule seems to fit the common practices better. Since the rule explicitly checks whether the individual directories exist anyway, there seems to be no reason to rely on make determining that implicitly as well.make sharedinstall
does not create lib-dynload in DESTDIR if lib-dynload exists in system already #100221