Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensurepip fails ungracefully when mimetype is missing from Windows registry #100256

Open
BlipRanger opened this issue Dec 14, 2022 · 2 comments
Open

Ensurepip fails ungracefully when mimetype is missing from Windows registry #100256

BlipRanger opened this issue Dec 14, 2022 · 2 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes easy extension-modules C modules in the Modules dir OS-windows topic-ensurepip triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error

Comments

@BlipRanger
Copy link

BlipRanger commented Dec 14, 2022 •
edited by bedevere-app bot
Loading

Bug report

A "WinError 5 Access is denied" error occurs when ensurepip (for python 3.10 and above) is run and there are missing/inaccessible mimetypes in the Windows registry. Because ensurepip is used in the Python installer, it also fails silently there, causing pip to never be installed without alerting the user to the issue. The line in which the error occurs is here:

cpython/Lib/mimetypes.py

Line 250 in 024ac54

_mimetypes_read_windows_registry(add_type)

Bypassing that line and instead using self._read_windows_registry(add_type) (which is the fallback function I believe) fixes the problem. I believe that _mimetypes_read_windows_registry(add_type) needs to be able to fail more gracefully when it can't find a particular mimetype in the registry.
I found someone else describing exactly the issue here.

Your environment

  • CPython versions tested on: 3.10, 3.11
  • Operating system and architecture: Windows 10 LTSC, x64

Linked PRs
@BlipRanger BlipRanger added the type-bug An unexpected behavior, bug, or error label Dec 14, 2022
@eryksun eryksun added OS-windows extension-modules C modules in the Modules dir 3.11 only security fixes 3.10 only security fixes 3.12 bugs and security fixes labels Dec 14, 2022
@huanghe2015
Copy link

Same thing happened with me ,Patrick and Stackoverflow.

@eryksun eryksun added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes easy triaged The issue has been accepted as valid by a triager. and removed 3.11 only security fixes 3.10 only security fixes labels Jun 18, 2024
LucasEsposito added a commit to LucasEsposito/cpython that referenced this issue Jul 19, 2024
@LucasEsposito
pythongh-100256: Read Windows registry with the fallback implementati…
0ffc526 
…on if the accelerated one fails
@bedevere-app bedevere-app bot mentioned this issue Jul 19, 2024
Merged
LucasEsposito added a commit to LucasEsposito/cpython that referenced this issue Jul 19, 2024
@LucasEsposito
pythongh-100256: Skip inaccessible registry keys in the WinAPI implem…
7b2e83b 
…entation
LucasEsposito added a commit to LucasEsposito/cpython that referenced this issue Jul 19, 2024
@LucasEsposito
pythongh-100256: Skip inaccessible registry keys in the mimetype WinA…
6922a1d 
…PI implementation
@LucasEsposito
Copy link
Contributor

Opened a PR to address this issue

LucasEsposito added a commit to LucasEsposito/cpython that referenced this issue Jul 21, 2024
@LucasEsposito
Merge branch 'main' into pythongh-100256-denied_access_to_windows_mim…
78a4bad 
…etype_registry_keys
LucasEsposito added a commit to LucasEsposito/cpython that referenced this issue Jul 21, 2024
@LucasEsposito
pythongh-100256: Skip inaccessible registry keys in the mimetype WinA…
f70f185 
…PI implementation
zooba pushed a commit that referenced this issue Aug 7, 2024
@LucasEsposito
gh-100256: Skip inaccessible registry keys in the WinAPI mimetype imp…
0bd9375 
…lementation (GH-122047)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 7, 2024
@LucasEsposito @miss-islington
pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…
b8950cb 
…pe implementation (pythonGH-122047)

(cherry picked from commit 0bd9375)

Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Aug 7, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 7, 2024
@LucasEsposito @miss-islington
pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…
00f3e4c 
…pe implementation (pythonGH-122047)

(cherry picked from commit 0bd9375)

Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Aug 7, 2024
Merged
zooba pushed a commit that referenced this issue Aug 7, 2024
@miss-islington @LucasEsposito
gh-100256: Skip inaccessible registry keys in the WinAPI mimetype imp…
8f4892a 
…lementation (GH-122047)

(cherry picked from commit 0bd9375)

Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@LucasEsposito @blhsing
pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…
b99701a 
…pe implementation (pythonGH-122047)
Yhg1s pushed a commit that referenced this issue Sep 2, 2024
@miss-islington @LucasEsposito
[3.13] gh-100256: Skip inaccessible registry keys in the WinAPI mimet…
f070398 
…ype implementation (GH-122047) (#122786)

gh-100256: Skip inaccessible registry keys in the WinAPI mimetype implementation (GH-122047)
(cherry picked from commit 0bd9375)

Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes easy extension-modules C modules in the Modules dir OS-windows topic-ensurepip triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@eryksun @BlipRanger @pradyunsg @huanghe2015 @LucasEsposito