bpo-45223: Lib/pty.py: handle stdin I/O errors same way as master I/O errors #28388
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
kanavin
force-pushed
the
fix-pty-spawn
branch
from
7a949ec to
87df07c
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
|
Just signed the CLA, will check in a few days if it's active. |
|
@kanavin Just checked now and it still says no |
If i type @kanavin into https://check-python-cla.herokuapp.com/ I get 500 Internal server error. How did you check? |
|
Need to use |
Right, I had it set on bpo with @. I removed that, and it looks good now. |
✅ Deploy Preview for python-cpython-preview canceled.
|
|
All commit authors signed the Contributor License Agreement. |
reading stdin can throw the same I/O errors as reading from master fd does,
e.g. when running under Yocto's test harness:
======================================================================
ERROR: test_spawn_doesnt_hang (test.test_pty.PtyTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3.10/test/test_pty.py", line 316, in test_spawn_doesnt_hang
pty.spawn([sys.executable, '-c', 'print("hi there")'])
File "/usr/lib/python3.10/pty.py", line 181, in spawn
_copy(master_fd, master_read, stdin_read)
File "/usr/lib/python3.10/pty.py", line 157, in _copy
data = stdin_read(STDIN_FILENO)
File "/usr/lib/python3.10/pty.py", line 132, in _read
return os.read(fd, 1024)
OSError: [Errno 5] Input/output error
So let's treat both channels the same.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
kanavin
force-pushed
the
fix-pty-spawn
branch
from
b0f657f to
924e0c3
Compare
|
@kanavin Can you explain the way to reproduce the error? I would like to try this in my local and check if the error still exists. |
We use this to run the tests: I just confirmed: when running |
reading stdin can throw the same I/O errors as reading from master fd does,
e.g. when running under Yocto's test harness:
ERROR: test_spawn_doesnt_hang (test.test_pty.PtyTest)
Traceback (most recent call last):
File "/usr/lib/python3.10/test/test_pty.py", line 316, in test_spawn_doesnt_hang
pty.spawn([sys.executable, '-c', 'print("hi there")'])
File "/usr/lib/python3.10/pty.py", line 181, in spawn
_copy(master_fd, master_read, stdin_read)
File "/usr/lib/python3.10/pty.py", line 157, in _copy
data = stdin_read(STDIN_FILENO)
File "/usr/lib/python3.10/pty.py", line 132, in _read
return os.read(fd, 1024)
OSError: [Errno 5] Input/output error
So let's treat both channels the same.
Signed-off-by: Alexander Kanavin alex@linutronix.de
https://bugs.python.org/issue45223