Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in the enum documentation #99960

Merged
merged 2 commits into from Dec 4, 2022
Merged

Fix typos in the enum documentation #99960

merged 2 commits into from Dec 4, 2022

Conversation

maggyero
Copy link
Contributor

@maggyero maggyero commented Dec 3, 2022

No description provided.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 3, 2022
@maggyero maggyero marked this pull request as ready for review Dec 3, 2022
@maggyero maggyero requested a review from ethanfurman as a code owner Dec 3, 2022
ethanfurman
ethanfurman requested changes Dec 3, 2022
View changes
Doc/library/enum.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Dec 3, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@maggyero
Copy link
Contributor Author

maggyero commented Dec 4, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Dec 4, 2022

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ethanfurman Dec 4, 2022
@ethanfurman ethanfurman merged commit 2ae894b into python:main Dec 4, 2022
14 checks passed
@ethanfurman
Copy link
Member

ethanfurman commented Dec 4, 2022

Many thanks!

@maggyero
Copy link
Contributor Author

maggyero commented Dec 4, 2022

Thanks for the review!

@maggyero maggyero deleted the patch-18 branch Dec 4, 2022
@itamaro itamaro mentioned this pull request Dec 6, 2022
Closed
@ethanfurman ethanfurman self-assigned this Dec 6, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Dec 6, 2022

Thanks @maggyero for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 6, 2022

GH-100051 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2022
@maggyero @miss-islington
[Enum] Fix typos in the documentation (pythonGH-99960)
1c96c2c 
(cherry picked from commit 2ae894b)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Dec 6, 2022
@miss-islington @maggyero
[Enum] Fix typos in the documentation (GH-99960)
05031ee 
(cherry picked from commit 2ae894b)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman

Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maggyero @bedevere-bot @ethanfurman @miss-islington