Skip to content

bpo-41995 :fix five possible Null Pointer Dereference bugs. #22635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

bpo-41995 :fix five possible Null Pointer Dereference bugs. #22635

merged 1 commit into from
Jan 20, 2021

Conversation

Yunlongs
Copy link
Contributor

@Yunlongs Yunlongs commented Oct 10, 2020 •
edited by bedevere-bot
Loading

fix five possible null pointer dereference bugs in https://bugs.python.org/issue41995.

https://bugs.python.org/issue41995

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Yunlongs

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

vstinner
vstinner reviewed Oct 11, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write a separated PR for the tracemalloc fix? It should be backported up to 3.8, whereas the zoneinfo fix should only be backported up to 3.9. It's just more convenient to have two separated PR.

The tracemalloc fix is correct :-)

@vstinner
Copy link
Member

cc @pganssle for the zoneinfo fix ;-)

@Yunlongs
Copy link
Contributor Author

Can you please write a separated PR for the tracemalloc fix? It should be backported up to 3.8, whereas the zoneinfo fix should only be backported up to 3.9. It's just more convenient to have two separated PR.

The tracemalloc fix is correct :-)

#22660

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 12, 2020 •
edited
Loading

Please add also a NEWS entry if this bug affects behavior and don't forget to sign the CLA.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@Yunlongs
Copy link
Contributor Author

Please add also a NEWS entry if this bug affects behavior and don't forget to sign the CLA.

Where to add NEWS entry?

@serhiy-storchaka
Copy link
Member

https://devguide.python.org/committing/#what-s-new-and-news-entries

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 24, 2020
@vstinner vstinner merged commit f1ff800 into python:master Jan 20, 2021
@vstinner
Copy link
Member

This PR is stale since October 2020. I prefer to merge it without document it rather than keeping the bugs.

@vstinner vstinner added the needs backport to 3.9 only security fixes label Jan 20, 2021
@miss-islington
Copy link
Contributor

Thanks @Yunlongs for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
@Yunlongs @miss-islington
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (p…
dc515e8 
…ythonGH-22635)

(cherry picked from commit f1ff800)

Co-authored-by: Yunlongs <lylgood@foxmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 20, 2021
@bedevere-bot
Copy link

GH-24261 is a backport of this pull request to the 3.9 branch.

@vstinner
Copy link
Member

Oh, _tracemalloc was fixed in commit 66c28f5.

miss-islington added a commit that referenced this pull request Jan 20, 2021
@miss-islington @Yunlongs
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (G…
50938b6 
…H-22635)

(cherry picked from commit f1ff800)

Co-authored-by: Yunlongs <lylgood@foxmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Yunlongs @adorilson
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (p…
8b3feec 
…ythonGH-22635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@pganssle pganssle Awaiting requested review from pganssle

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yunlongs @the-knights-who-say-ni @vstinner @serhiy-storchaka @miss-islington @bedevere-bot @corona10 @pablogsal