Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-93521: Filter out __weakref__ slot if present in bases #93535

Merged
merged 4 commits into from Jun 8, 2022
Merged

GH-93521: Filter out __weakref__ slot if present in bases #93535

merged 4 commits into from Jun 8, 2022
+61 −4

Conversation

Bluenix2
Copy link
Contributor

@Bluenix2 Bluenix2 commented Jun 6, 2022

This PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.

@Bluenix2 Bluenix2 requested a review from ericvsmith as a code owner Jun 6, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@Bluenix2
Copy link
Contributor Author

@Bluenix2 Bluenix2 commented Jun 6, 2022

I am not sure why my commit was changed to pythonGH rather than GH by GitHub...

ericvsmith
ericvsmith requested changes Jun 6, 2022
View changes
Lib/test/test_dataclasses.py Show resolved Hide resolved
Lib/test/test_dataclasses.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-06-06-13-19-43.gh-issue-93521._vE8m9.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Bluenix2 Bluenix2 requested a review from ericvsmith Jun 6, 2022
@Bluenix2
Copy link
Contributor Author

@Bluenix2 Bluenix2 commented Jun 6, 2022

Ah sorry I requested your review through GitHub but I'll send a message to be clear. I have addressed your comments and pushed new changes which are passing checks.

@ericvsmith ericvsmith self-assigned this Jun 8, 2022
@ericvsmith ericvsmith merged commit 5849af7 into python:main Jun 8, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 8, 2022

Thanks @Bluenix2 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2022

GH-93594 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 8, 2022
@Bluenix2 @miss-islington
pythonGH-93521: For dataclasses, filter out __weakref__ slot if pre…
79dabf2 
…sent in bases (pythonGH-93535)

(cherry picked from commit 5849af7)

Co-authored-by: Bluenix <bluenixdev@gmail.com>
miss-islington added a commit that referenced this issue Jun 8, 2022
@miss-islington @Bluenix2
GH-93521: For dataclasses, filter out __weakref__ slot if present i…
121ab58 
…n bases (GH-93535)

(cherry picked from commit 5849af7)

Co-authored-by: Bluenix <bluenixdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith

Assignees

@ericvsmith ericvsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot specify weakref_slot=True twice in dataclass MRO
4 participants
@Bluenix2 @bedevere-bot @miss-islington @ericvsmith