Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-82874: Convert remaining importlib format uses to f-str. #98005

Merged
merged 2 commits into from Oct 7, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Oct 7, 2022

Converts the remaining importlib str.format() uses to f-strings.

@gpshead gpshead added stdlib Python modules in the Lib dir expert-importlib labels Oct 7, 2022
@gpshead gpshead requested a review from ericvsmith Oct 7, 2022
@gpshead gpshead changed the title Convert remaining importlib format uses to f-str. gh-82874: Convert remaining importlib format uses to f-str. Oct 7, 2022
@gpshead gpshead marked this pull request as ready for review Oct 7, 2022
Lib/importlib/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@ericvsmith ericvsmith left a comment

Other than the one error, looks okay to me.

Lib/importlib/__init__.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead gpshead merged commit 27369ef into python:main Oct 7, 2022
14 checks passed
@gpshead gpshead deleted the more-importlib-f-yes branch Oct 7, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expert-importlib stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants