Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35964: shutil.make_archive (xxx, tar, root_dir) is adding './' entry to archive which is wrong #13738

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

bpo-35964: shutil.make_archive (xxx, tar, root_dir) is adding './' entry to archive which is wrong #13738

wants to merge 8 commits into from
+9 −5

Conversation

websurfer5
Copy link
Contributor

@websurfer5 websurfer5 commented Jun 2, 2019 •
edited by bedevere-bot

Exclude '.' directory entries when adding directories to a tar archive.

https://bugs.python.org/issue35964

auvipy
auvipy approved these changes Jun 2, 2019
View changes
@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 3, 2019
@taleinat taleinat changed the title bpo-35964: sshutil.make_archive (xxx, tar, root_dir) is adding './' entry to archive which is wrong bpo-35964: shutil.make_archive (xxx, tar, root_dir) is adding './' entry to archive which is wrong Jun 29, 2019
taleinat
taleinat requested changes Jun 29, 2019
View changes
Copy link
Contributor

@taleinat taleinat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the change to shutil warrants a mention in "What's New". The similar fix for zip archives did not add such a mention. The "What's New" line about the change to tarfile is fine IMO, though.

Also, since this changes the tarfile module (rather than shutil), this also should be tested in the tar module's tests.

Lib/tarfile.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

taleinat
taleinat reviewed Jul 3, 2019
View changes
Lib/tarfile.py Outdated Show resolved Hide resolved
@taleinat taleinat requested a review from gustaebel Jul 11, 2019
taleinat
taleinat approved these changes Jul 11, 2019
View changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This should also be reviewed by @gustaebel, the expert on the tarfile module.

@HFM HFM mannequin mentioned this pull request Apr 10, 2022
Open
@hauntsaninja hauntsaninja requested a review from ethanfurman as a code owner Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

@auvipy auvipy

@gustaebel gustaebel

@ethanfurman ethanfurman

Assignees
No one assigned
Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@websurfer5 @bedevere-bot @taleinat @auvipy @brettcannon @gustaebel @the-knights-who-say-ni @ezio-melotti @hauntsaninja