Skip to content

[3.7] bpo-34010: Fix tarfile read performance regression (GH-8020) #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

[3.7] bpo-34010: Fix tarfile read performance regression (GH-8020) #8082

merged 1 commit into from
Jul 4, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 4, 2018 •
edited by bedevere-bot
Loading

During buffered read, use a list followed by join instead of extending a bytes object.
This is how it was done before but changed in commit b506dc3.
(cherry picked from commit 12a08c4)

Co-authored-by: hajoscher hajoscher@gmail.com

https://bugs.python.org/issue34010

@hajoscher @miss-islington
bpo-34010: Fix tarfile read performance regression (pythonGH-8020)
cdcd774 
During buffered read, use a list followed by join instead of extending a bytes object.
This is how it was done before but changed in commit b506dc3.
(cherry picked from commit 12a08c4)

Co-authored-by: hajoscher <hajoscher@gmail.com>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error performance Performance or resource usage labels Jul 4, 2018
@bedevere-bot bedevere-bot mentioned this pull request Jul 4, 2018
Merged
@miss-islington
Copy link
Contributor Author

@hajoscher and @methane: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c1b75b5 into python:3.7 Jul 4, 2018
@miss-islington miss-islington deleted the backport-12a08c4-3.7 branch July 4, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @methane @the-knights-who-say-ni @bedevere-bot @hajoscher