bpo-35931: Gracefully handle any exception in pdb debug command #12103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is relevant for `debug doesnotexist()`, which would crash with a NameError otherwise.
blueyed
added a commit
to pdbpp/pdbpp
that referenced
this pull request
Mar 9, 2019
blueyed
added a commit
to pdbpp/pdbpp
that referenced
this pull request
Mar 9, 2019
blueyed
added a commit
to pdbpp/pdbpp
that referenced
this pull request
Mar 9, 2019
blueyed
added a commit
to pdbpp/pdbpp
that referenced
this pull request
Mar 9, 2019
* do_debug: harden and fix for py38-dev (v3.8.0a2) Based on python/cpython#12103. * ci: Travis: do not allow failure with py38
|
Yep, this is a rather better fix :). For NEWS, let's just write it as a new one: This does bring up the question, what behavior is desired from BaseException subclasses (KeyboardInterrupt in particular)? |
zware
added
needs backport to 3.7
zware
approved these changes
Mar 12, 2019
|
@blueyed: Status check is done, and it's a success |
|
Thanks @blueyed for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 12, 2019
…onGH-12103) This is relevant for `debug doesnotexist()`, which would crash with a NameError otherwise. (cherry picked from commit 3e93643) Co-authored-by: Daniel Hahler <github@thequod.de>
|
GH-12285 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 12, 2019
…GH-12103) (GH-12285) This is relevant for `debug doesnotexist()`, which would crash with a NameError otherwise. (cherry picked from commit 3e93643) Co-authored-by: Daniel Hahler <github@thequod.de> https://bugs.python.org/issue35931
blueyed
added a commit
to blueyed/rebased-pdbpp
that referenced
this pull request
May 25, 2019
* do_debug: harden and fix for py38-dev (v3.8.0a2) Based on python/cpython#12103. * ci: Travis: do not allow failure with py38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is relevant for
debug doesnotexist(), which would crash with aNameError otherwise.