Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-40431: Fix syntax typo in turtledemo (GH-19777) #19784

Merged
merged 3 commits into from Apr 29, 2020

Conversation

aeros
Copy link
Member

@aeros aeros commented Apr 29, 2020

Backport for GH-19777, but it removes the Misc/NEWS entry since the typo is not a SyntaxError in versions prior to 3.9.

https://bugs.python.org/issue40431

hroncok and others added 3 commits Apr 29, 2020
***   File "/usr/lib64/python3.9/turtledemo/__main__.py", line 275
        bg="GH-d00" if clear == NORMAL else"GH-fca")
                                        ^
    SyntaxError: invalid string prefix
(cherry picked from commit 49f70db)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
***   File "/usr/lib64/python3.9/turtledemo/__main__.py", line 275
        bg="GH-d00" if clear == NORMAL else"GH-fca")
                                        ^
    SyntaxError: invalid string prefix.
(cherry picked from commit 49f70db)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@aeros aeros merged commit cc011b5 into python:3.8 Apr 29, 2020
5 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Apr 29, 2020

@aeros: Please replace # with GH- in the commit message next time. Thanks!

@aeros
Copy link
Member Author

aeros commented Apr 29, 2020

Please replace # with GH- in the commit message next time. Thanks!

I've been forgetting it less often now, but I'm still getting the hang of it. I couldn't use automerge for this PR since I had to clean up the commit message.

@miss-islington
Copy link
Contributor

miss-islington commented Apr 29, 2020

Thanks @aeros for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2020
…onGH-19784)

[3.8] bpo-40431: Fix syntax typo in turtledemo (pythonGH-19777)

* Addresses a syntax typo that mistakenly used a undefined string prefix due to a missing space.

(cherry picked from commit 49f70db)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
(cherry picked from commit cc011b5)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 29, 2020

GH-19789 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 29, 2020
[3.8] bpo-40431: Fix syntax typo in turtledemo (GH-19777)

* Addresses a syntax typo that mistakenly used a undefined string prefix due to a missing space.

(cherry picked from commit 49f70db)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
(cherry picked from commit cc011b5)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants