Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326

wants to merge 2 commits into from

Conversation

BenjaminLiuPenrose
Copy link

@BenjaminLiuPenrose BenjaminLiuPenrose commented Apr 3, 2020 •
edited by bedevere-bot

Reference Issues/PRs

bpo-40167 https://bugs.python.org/issue40167
fixes cython project issue in cython/cython#3405

What does this implement/fix? Explain your changes.

fix Cython files don't compile on Mingw-w64 64-bit problem

https://bugs.python.org/issue40167

@BenjaminLiuPenrose BenjaminLiuPenrose requested a review from a team as a code owner Apr 3, 2020
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 3, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BenjaminLiuPenrose

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@BenjaminLiuPenrose BenjaminLiuPenrose changed the title Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Apr 3, 2020
@BenjaminLiuPenrose
Copy link
Author

BenjaminLiuPenrose commented Apr 4, 2020

Hi, I already signed CLA with my github account

taleinat
taleinat requested changes Sep 26, 2020
View changes
Misc/NEWS.d/next/Windows/2020-01-24-09-15-41.bpo-8901.hVnhGO.rst
Add Mingw-w64 64-bit windows machine, fix issue
in https://bugs.python.org/issue40167
Copy link
Contributor

@taleinat taleinat Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to create a new NEWS entry file rather than adding this to an existing one. Use blurb-it or blurb.

PC/pyconfig.h
@@ -78,6 +78,11 @@ WIN32 is still required for the locale module.


/* Compiler specific defines */
#ifdef __MINGW32__
Copy link
Contributor

@taleinat taleinat Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why and when this is needed.

@bedevere-bot
Copy link

bedevere-bot commented Sep 26, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatriel iritkatriel changed the title bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Oct 20, 2021
@iritkatriel
Copy link
Member

iritkatriel commented Oct 20, 2021 •
edited by bedevere-bot

Closed bpo-40167 as a duplicate of an older bpo-35037 which has more info. Please update the PR as requested by @taleinat

@imba-tjd imba-tjd mentioned this pull request Jan 27, 2022
Closed
1 task
@jimboyeah
Copy link

jimboyeah commented Apr 7, 2022

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.

1 similar comment
@jimboyeah
Copy link

jimboyeah commented Apr 7, 2022

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.

@taleinat
Copy link
Contributor

taleinat commented Apr 7, 2022 •
edited

The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested.

Is anyone else interested in bringing this to completion? @jimboyeah?

@scoder scoder mentioned this pull request Aug 5, 2022
Open
@GalaxySnail GalaxySnail mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

@python/windows-team windows-team

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@BenjaminLiuPenrose @the-knights-who-say-ni @bedevere-bot @iritkatriel @jimboyeah @taleinat @csabella @ezio-melotti