Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows readme.txt to clarify Visual Studio required versions #99522

Merged
merged 1 commit into from Nov 16, 2022

Conversation

BenJKuhn
Copy link
Contributor

@BenJKuhn BenJKuhn commented Nov 16, 2022

This is just a minor update to add a clarification to the requirements in the Windows build readme.

Automerge-Triggered-By: GH:zooba

@BenJKuhn BenJKuhn requested a review from a team as a code owner Nov 16, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Nov 16, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

zooba
zooba approved these changes Nov 16, 2022
@zooba zooba added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 16, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2022

@BenJKuhn: Status check is done, and it's a failure or timed out .

@BenJKuhn
Copy link
Contributor Author

BenJKuhn commented Nov 16, 2022

The failure is unrelated to change and appears to be a race on a file handle. Is there a way to trigger a re-run?

@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2022

Status check is done, and it's a success .

@miss-islington miss-islington merged commit 4636df9 into python:main Nov 16, 2022
13 checks passed
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
* main: (8272 commits)
  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)
  pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)
  pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)
  pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)
  Post 3.12.0a2
  pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)
  pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)
  pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)
  pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)
  pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)
  pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)
  pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)
  pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)
  pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)
  pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)
  pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)
  pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)
  pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants