Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many misses in BINARY_SUBSCR_LIST_INT #100188

Closed
sweeneyde opened this issue Dec 12, 2022 · 1 comment
Closed

Too many misses in BINARY_SUBSCR_LIST_INT #100188

sweeneyde opened this issue Dec 12, 2022 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@sweeneyde
Copy link
Member

sweeneyde commented Dec 12, 2022 •
edited

The expression my_list[-1] gets specialized to BINARY_SUBSCR_LIST_INT every time, then it gets deoptimized every time

This leads to 31%ish of BINARY_SUBSCR_LIST_INT executions being misses (on some programs anyway). Edit: this stat was probably not accurate.

Should be an easy fix.

Linked PRs
@sweeneyde sweeneyde added the type-feature A feature request or enhancement label Dec 12, 2022
@bedevere-bot bedevere-bot mentioned this issue Dec 12, 2022
Merged
sweeneyde added a commit that referenced this issue Dec 20, 2022
@sweeneyde
gh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (#100189)
c18d831 
Don't specialize if the index is negative.
@hauntsaninja
Copy link
Contributor

hauntsaninja commented Dec 21, 2022

Thanks for finding and fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hauntsaninja @sweeneyde @kumaraditya303