gh-93814: Add infinite test for itertools.chain.from_iterable #93815
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safe, but not tested
|
Thanks for the PR, but I don't think it adds any value. There is nothing about the iterator protocol that differentiates between infinite iterators and partially consumed iterators. So, we're not increasing test coverage in any way. Please see the comment on the GitHub issue. |
|
After more thought, there may be some value to this test in that it checks that the input iterable is consumed lazily; otherwise, this test would never finish. There may be more economical ways to write this test, but the one proposed will suffice. |
rhettinger
approved these changes
Jun 14, 2022
rhettinger
added
the
|
Status check is done, and it's a success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fix #93814
Automerge-Triggered-By: GH:rhettinger