Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31323: Fix reference leak in test_ssl #3263

Merged
merged 1 commit into from Sep 1, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 1, 2017

Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.

https://bugs.python.org/issue31323

Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.
@vstinner vstinner requested a review from tiran as a code owner Sep 1, 2017
@vstinner vstinner merged commit 8687101 into python:master Sep 1, 2017
@vstinner vstinner deleted the ssl_refcycle branch Sep 1, 2017
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request Sep 4, 2017
* 'master' of https://github.com/python/cpython: (601 commits)
  remove check for bug last seem in Solaris 9 (python#3285)
  Change code owners for hashlib and ssl to the crypto team (python#3284)
  bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208)
  remove autoconf check for select() (python#3283)
  remove configure check for 'volatile' (python#3281)
  Add missing _sha3 module to Setup.dist (python#2395)
  bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278)
  bpo-9146: add the missing NEWS entry. (python#3275)
  Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270)
  bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076)
  remove a redundant lower in urllib.parse.urlsplit (python#3008)
  bpo-31323: Fix reference leak in test_ssl (python#3263)
  bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264)
  bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265)
  bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560)
  bpo-31250, test_asyncio: fix dangling threads (python#3252)
  bpo-31217: Fix regrtest -R for small integer (python#3260)
  bpo-30096: Use ABC in abc reference examples (python#1220)
  bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
  [Trivial] Remove now redundant assert (python#3245)
  ...
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2017

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2017
Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.
(cherry picked from commit 8687101)
@bedevere-bot
Copy link

bedevere-bot commented Sep 13, 2017

GH-3538 is a backport of this pull request to the 3.6 branch.

vstinner pushed a commit that referenced this pull request Sep 13, 2017
Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.
(cherry picked from commit 8687101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants