Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95027: Ensure test runner uses utf-8:surrogateescape for communicating with subprocesses #96669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-95027: Ensure test runner uses utf-8:surrogateescape for communicating with subprocesses #96669

wants to merge 1 commit into from
+9 −1

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 7, 2022 •
edited by bedevere-bot

@terryjreedy
Copy link
Member

terryjreedy commented Sep 8, 2022 •
edited

I tried to hand-apply this patch to installed 3.11.0rc1, but Lib/test/libregrtest/runtest_mp.py has changed too much. I tried copying the patched 3.12 libregrtest into 3.11, but that did not work either. I then ran the test with -j0 in updated main and got the same error as on the issue. Finally, I created a branch from this pr and ran the tests in paralled again and they ran to completion. So this patch appears to fix the issue I reported. (There were other problems -- see issue.) So from my viewpoint, it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zooba @terryjreedy @bedevere-bot