Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89653: PEP 670: Convert PyCell macros to functions #92653

Merged
merged 1 commit into from May 11, 2022
Merged

gh-89653: PEP 670: Convert PyCell macros to functions #92653

merged 1 commit into from May 11, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 11, 2022

Convert the following macros to static inline functions:

  • PyCell_GET()
  • PyCell_SET()

Limited C API version 3.12 no longer casts arguments.

Fix also usage of PyCell_SET(): only delete the old value after
setting the new value.

@vstinner
pythongh-89653: PEP 670: Convert PyCell macros to functions
652d772 
Convert the following macros to static inline functions:

* PyCell_GET()
* PyCell_SET()

Limited C API version 3.12 no longer casts arguments.

Fix also usage of PyCell_SET(): only delete the old value after
setting the new value.
@vstinner vstinner requested a review from markshannon as a code owner May 11, 2022
@vstinner
Copy link
Member Author

@vstinner vstinner commented May 11, 2022

cc @erlend-aasland

@vstinner vstinner mentioned this pull request May 11, 2022
Merged
@vstinner vstinner merged commit 897f14d into python:main May 11, 2022
12 checks passed
@vstinner vstinner deleted the cell_macros branch May 11, 2022
@vstinner vstinner mentioned this pull request May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vstinner @bedevere-bot