New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs in asyncio.Future.remove_done_callback() cause segfault. #97592
Comments
Yeah, I can still repro this on 3.11. It doesn't crash when the pure-Python asyncio implementation is used ( Someone needs to look into the code there and see what is happening. |
I simply debugged with the following code: import asyncio
async def crash():
fut = asyncio.Future()
fut.add_done_callback(str)
for _ in range(10):
fut.add_done_callback(id)
class Evil:
def __eq__(self, other):
fut.remove_done_callback(other)
fut.remove_done_callback(Evil())
asyncio.create_task(set_after(fut, 1, '... world'))
print('hello ...')
print(await fut)
if __name__ == "__main__":
asyncio.run(crash()) The core dump seems to happen in the static PyObject *
_asyncio_Future_remove_done_callback(FutureObj *self, PyObject *fn)
{
...
// The `self->fut_callbacks` here is a nullptr, which causes the core dump
for (i = 0; i < PyList_GET_SIZE(self->fut_callbacks); i++) {
int ret;
PyObject *item = PyList_GET_ITEM(self->fut_callbacks, i);
Py_INCREF(item);
ret = PyObject_RichCompareBool(PyTuple_GET_ITEM(item, 0), fn, Py_EQ);
if (ret == 0) {
if (j < len) {
PyList_SET_ITEM(newlist, j, item);
j++;
continue;
}
ret = PyList_Append(newlist, item);
}
Py_DECREF(item);
if (ret < 0) {
goto fail;
}
}
if (j == 0) {
Py_CLEAR(self->fut_callbacks);
Py_DECREF(newlist);
return PyLong_FromSsize_t(len + cleared_callback0);
}
} |
Thanks, that's good research! The cause is now clear: the The fix would seem to require some check for whether Do you want to create the PR to get full credit? |
Thanks for your guidance! I notice that you have created a commit, I wonder if it would be better to add a test case that can trigger the crash :) |
xiaxinmeng commentedSep 27, 2022
Crash report
The following example triggers a segfault on the latest stable Python3.8.14. I think there might be a bug in asyncio.Future.remove_done_callback().
Error messages
Segmentation fault (core dumped)
Your environment
The text was updated successfully, but these errors were encountered: