Skip to content

asyncio: Add PHA for TLS 1.3 #79028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fantix mannequin opened this issue Sep 30, 2018 · 5 comments
Closed

asyncio: Add PHA for TLS 1.3 #79028

fantix mannequin opened this issue Sep 30, 2018 · 5 comments
Labels
topic-asyncio type-feature A feature request or enhancement

Comments

@fantix
Copy link
Mannequin

fantix mannequin commented Sep 30, 2018

BPO 34847
Nosy @fantix, @asvetlov, @1st1
PRs
  • bpo-34670: Add TLS 1.3 post handshake auth #9460
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2018-09-30.03:52:14.621>
labels = ['type-bug', '3.8', 'expert-asyncio']
title = 'asyncio: Add PHA for TLS 1.3'
updated_at = <Date 2018-09-30.03:54:16.138>
user = 'https://github.com/fantix'

    bugs.python.org fields:

    activity = <Date 2018-09-30.03:54:16.138>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['asyncio']
creation = <Date 2018-09-30.03:52:14.621>
creator = 'fantix'
dependencies = []
files = []
hgrepos = []
issue_num = 34847
keywords = ['patch']
message_count = 1.0
messages = ['326700']
nosy_count = 3.0
nosy_names = ['fantix', 'asvetlov', 'yselivanov']
pr_nums = ['9460']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34847'
versions = ['Python 3.8']
    @fantix
    Copy link
    Mannequin Author

    fantix mannequin commented Sep 30, 2018

    This was raised in GH-9460 where the same post handshake authentication (PHA) was added to the ssl module. It should be added to asyncio too. This issue is to discuss the design of PHA API in asyncio, and implement it in Python 3.8.

    One approach is to add _SSLProtocolTransport.verify_client_post_handshake(), but an additional new transport mixin type to asyncio/transports.py would be needed (Yury).

    Yury also proposed another option to use get_extra_info() API to get something like an "SSLExtra" object with additional APIs.

    @fantix fantix mannequin added 3.8 (EOL) end of life topic-asyncio type-bug An unexpected behavior, bug, or error labels Sep 30, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @ezio-melotti ezio-melotti moved this to Todo in asyncio Jul 17, 2022
    @kumaraditya303 kumaraditya303 added type-feature A feature request or enhancement and removed 3.8 (EOL) end of life labels Sep 29, 2022
    @kumaraditya303 kumaraditya303 removed the type-bug An unexpected behavior, bug, or error label Oct 15, 2022
    @kumaraditya303
    Copy link
    Contributor

    There have been no user requests for this feature and we are unlikely to expand the tls API hence closing.

    @kumaraditya303 kumaraditya303 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
    @github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Apr 20, 2023
    @jborean93
    Copy link
    Contributor

    In case this is still being read I was hoping for this functionality to support creating a WSMan service for Windows Event Forwarding. The WSMan service uses the post handshake auth feature for certificate authentication.

    @gvanrossum
    Copy link
    Member

    I'm sorry but nobody appears to be available to implement this.

    @jborean93
    Copy link
    Contributor

    All good I assumed as much, just wanted to put it out there some use cases of such a feature. I'm looking into alternatives but alas I think I need to manually wrap my data with wrap_bio as the sync variant only seems to work when you send actual data with no way of just doing the new handshake only.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-asyncio type-feature A feature request or enhancement
    Projects
    asyncio
    Status: Done
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gvanrossum @jborean93 @kumaraditya303