Skip to content

[3.7] bpo-35412: Add testcase to test_future4 (GH-11131) #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 16, 2018

Add testcase to test_future4: check unicode literal.
(cherry picked from commit 502fe19)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue35412

Add testcase to test_future4: check unicode literal.
(cherry picked from commit 502fe19)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Dec 16, 2018

Sorry, I can't merge this PR. Reason: `Invalid request.

For 'properties/commit_message', ["bpo-35412: Add testcase to test_future4 (GH-11131)", "", "Add testcase to test_future4: check unicode literal.", "(cherry picked from commit 502fe19)", "", "Co-authored-by: Victor Stinner vstinner@redhat.com"] is not a string.`.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Dec 16, 2018

Sorry, I can't merge this PR. Reason: `Invalid request.

For 'properties/commit_message', ["bpo-35412: Add testcase to test_future4 (GH-11131)", "", "Add testcase to test_future4: check unicode literal.", "(cherry picked from commit 502fe19)", "", "Co-authored-by: Victor Stinner vstinner@redhat.com"] is not a string.`.

@vstinner vstinner merged commit 2d91a13 into python:3.7 Dec 17, 2018
@miss-islington miss-islington deleted the backport-502fe19-3.7 branch December 17, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants