Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-36365: Rewrite structseq_repr() using _PyUnicodeWriter #12440
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Mar 19, 2019
bedevere-bot
added
the
awaiting merge
label
Mar 19, 2019
vstinner
merged commit c70ab02
into
python:master
Mar 19, 2019
5 checks passed
bedevere-bot
removed
the
awaiting merge
label
Mar 19, 2019
vstinner
deleted the
vstinner:structseq_writer
branch
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vstinner commentedMar 19, 2019
•
edited by bedevere-bot
No longer limit repr(structseq) to 512 bytes. Use _PyUnicodeWriter
for better performance and write directly Unicode rather than using
encode repr() value to UTF-8 and then decode from UTF-8.
https://bugs.python.org/issue36365