Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46425: fix direct invocation of test_sqlite3 #30676

Merged
merged 1 commit into from Jan 22, 2022
Merged

bpo-46425: fix direct invocation of test_sqlite3 #30676

merged 1 commit into from Jan 22, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 18, 2022 •
edited by bedevere-bot

This fixes ./python.exe Lib/test/test_sqlite3/... tests.
Without this change it fails:

» ./python.exe Lib/test/test_sqlite3/test_transactions.py 
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_sqlite3/test_transactions.py", line 26, in <module>
    from .test_dbapi import memory_database
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: attempted relative import with no known parent package

Refs #30666
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

@sobolevn sobolevn requested a review from berkerpeksag as a code owner Jan 18, 2022
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
@zware zware requested a review from erlend-aasland Jan 18, 2022
@zware zware changed the title bpo-46425: fix direct invokation of test_sqlite3 bpo-46425: fix direct invocation of test_sqlite3 Jan 18, 2022
erlend-aasland
erlend-aasland approved these changes Jan 18, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

lgtm, thanks!

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 18, 2022 •
edited

This should not be backported. The sqlite3 test suite has changed a lot since 3.10 and 3.9. I don't think this would apply cleanly at all. IMO, I don't think it is worth backporting it.

@asvetlov asvetlov merged commit 55f4ec4 into python:main Jan 22, 2022
11 checks passed
@sobolevn sobolevn mentioned this pull request Apr 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@JelleZijlstra JelleZijlstra

@erlend-aasland erlend-aasland

@kumaraditya303 kumaraditya303

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sobolevn @erlend-aasland @asvetlov @JelleZijlstra @kumaraditya303 @the-knights-who-say-ni @bedevere-bot