Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge LOAD_METHOD back into LOAD_ATTR for better specialization #93429

Closed
Fidget-Spinner opened this issue Jun 2, 2022 · 1 comment · Fixed by #93430 or #93803
Closed

Merge LOAD_METHOD back into LOAD_ATTR for better specialization #93429

Fidget-Spinner opened this issue Jun 2, 2022 · 1 comment · Fixed by #93430 or #93803
Labels
3.12 performance type-feature

Comments

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 2, 2022

LOAD_METHOD split off from LOAD_ATTR in 3.7 as a compiler based optimisation.

I proposed to merge it back to enable better specialization. The actual LOAD_METHOD instruction is left around as a virtual instruction at the moment.

See faster-cpython/ideas#400 (reply in thread)
@Fidget-Spinner Fidget-Spinner added type-feature performance 3.12 labels Jun 2, 2022
@Fidget-Spinner Fidget-Spinner mentioned this issue Jun 2, 2022
Merged
@Fidget-Spinner Fidget-Spinner mentioned this issue Jun 10, 2022
Open
markshannon pushed a commit that referenced this issue Jun 14, 2022
@Fidget-Spinner
GH-93429: Merge LOAD_METHOD back into LOAD_ATTR (GH-93430)
b083450
@Fidget-Spinner
Copy link
Member Author

@Fidget-Spinner Fidget-Spinner commented Jun 14, 2022

Reopening to remind myself to complete docs.

@Fidget-Spinner Fidget-Spinner mentioned this issue Jun 14, 2022
Merged
Fidget-Spinner added a commit that referenced this issue Jun 14, 2022
@Fidget-Spinner
GH-93429: Document LOAD_METHOD removal (GH-93803)
38a7f78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 performance type-feature
Projects
None yet
Milestone
No milestone
1 participant
@Fidget-Spinner