Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100005: Skip test_script_as_dev_fd() on FreeBSD #100006

Merged
merged 1 commit into from Dec 5, 2022
Merged

gh-100005: Skip test_script_as_dev_fd() on FreeBSD #100006

merged 1 commit into from Dec 5, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2022 •
edited by bedevere-bot

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if fdescfs is not mounted (at /dev/fd).

@vstinner
gh-100005: Skip test_script_as_dev_fd() on FreeBSD
ad8744f 
On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
@vstinner vstinner requested a review from gpshead as a code owner Dec 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 5, 2022
@vstinner
Copy link
Member Author

vstinner commented Dec 5, 2022

With this PR, the test is now skipped on FreeBSD:

$ ./python -m test test_cmd_line_script -v -m test_script_as_dev_fd
(...)
test_script_as_dev_fd (test.test_cmd_line_script.CmdLineTest.test_script_as_dev_fd) ... skipped 'Requires fdescfs mounted on /dev/fd on FreeBSD'

If I mount manually /dev/fd, it works as expected:

$ sudo mount -t fdescfs none /dev/fd 

$ ./python -m test test_cmd_line_script -v -m test_script_as_dev_fd
(...)
test_script_as_dev_fd (test.test_cmd_line_script.CmdLineTest.test_script_as_dev_fd) ... 

/usr/home/vstinner/python/main/Lib/subprocess.py:849: RuntimeWarning: pass_fds overriding close_fds.
  warnings.warn("pass_fds overriding close_fds.", RuntimeWarning)

ok
(...)

cc @ronaldoussoren

By the way, the test emits a warning because of this Lib/subprocess.py code:

            if pass_fds and not close_fds:
                warnings.warn("pass_fds overriding close_fds.", RuntimeWarning)
                close_fds = True

@vstinner vstinner mentioned this pull request Dec 5, 2022
Open
@vstinner vstinner mentioned this pull request Dec 5, 2022
Open
@vstinner vstinner merged commit 038b151 into python:main Dec 5, 2022
13 checks passed
@vstinner vstinner deleted the test_script_as_dev_fd branch Dec 5, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Sorry, @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 038b151963d9d4a5f4c852544fb5b0402ffcb218 3.10

@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100007 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@vstinner @miss-islington
pythongh-100005: Skip test_script_as_dev_fd() on FreeBSD (pythonGH-10…
2fcc46c 
…0006)

On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
Member Author

vstinner commented Dec 5, 2022

Ah, test_script_as_dev_fd() was not backported to Python 3.10.

miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @vstinner
gh-100005: Skip test_script_as_dev_fd() on FreeBSD (GH-100006)
5533cf6 
On FreeBSD, skip test_script_as_dev_fd() of test_cmd_line_script if
fdescfs is not mounted (at /dev/fd).
(cherry picked from commit 038b151)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@vstinner vstinner

Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @miss-islington @bedevere-bot