Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve threading.daemon docstring #14278

Merged
merged 1 commit into from Jun 22, 2019
Merged

Improve threading.daemon docstring #14278

merged 1 commit into from Jun 22, 2019

Conversation

mbarkhau
Copy link
Contributor

@mbarkhau mbarkhau commented Jun 20, 2019

Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.html#thread-objects.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jun 20, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@Mariatta Mariatta changed the title Remove double negative in Thread.daemon.__doc__ Improve threading.daemon docstring Jun 20, 2019
@Mariatta Mariatta added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jun 20, 2019
@Mariatta
Copy link
Sponsor Member

Mariatta commented Jun 20, 2019

Thanks. Once you sign the CLA, it can be automatically merged.

Does this need to be backported?

@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

Thanks @mbarkhau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

Thanks @mbarkhau for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 23, 2019

Thanks @mbarkhau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 23, 2019

GH-14323 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jun 23, 2019

GH-14324 is a backport of this pull request to the 2.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jun 23, 2019

GH-14325 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
miss-islington added a commit that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
miss-islington added a commit that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
miss-islington added a commit that referenced this pull request Jun 23, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.htmlGH-thread-objects.
(cherry picked from commit bb110cc)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.html#thread-objects.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Rephrase and clarify that "the entire Python program exits when only daemon threads are left". This matches the documentation at https://docs.python.org/3/library/threading.html#thread-objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants