gh-98783: Fix crashes when str subclasses where used in _PyUnicode_Equal
#98806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows failure is unrelated, but I will retrigger anyway. |
sweeneyde
approved these changes
Oct 28, 2022
sweeneyde
reviewed
Oct 28, 2022
Misc/NEWS.d/next/Core and Builtins/2022-10-28-14-52-55.gh-issue-98783.iG0kMs.rst
Outdated
Show resolved
Hide resolved
sweeneyde
reviewed
Oct 29, 2022
Misc/NEWS.d/next/Core and Builtins/2022-10-28-14-52-55.gh-issue-98783.iG0kMs.rst
Outdated
Show resolved
Hide resolved
…e-98783.iG0kMs.rst Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
Thanks @sobolevn for the PR, and @sweeneyde for merging it |
|
Sorry @sobolevn and @sweeneyde, I had trouble checking out the |
|
Thanks @sobolevn for the PR, and @sweeneyde for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 30, 2022
…code_Equal` (pythonGH-98806) (cherry picked from commit 76f989d) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-98869 is a backport of this pull request to the 3.11 branch. |
|
GH-98871 is a backport of this pull request to the 3.11 branch. |
|
Thank you for your help! |
sweeneyde
added a commit
that referenced
this pull request
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Thanks a lot for your help, @sweeneyde!
int.from_bytescrashes ifbyteorderis a string subclass #98783