Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup #94298

Merged
merged 2 commits into from Jun 28, 2022
Merged

GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup #94298

merged 2 commits into from Jun 28, 2022
+27 −1

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 26, 2022 •
edited by bedevere-bot

@kumaraditya303 kumaraditya303 self-assigned this Jun 26, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Jun 28, 2022
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

👍

@serhiy-storchaka serhiy-storchaka merged commit 01ef1f9 into python:main Jun 28, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 28, 2022

Thanks @kumaraditya303 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 28, 2022

Sorry, @kumaraditya303 and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 01ef1f95dab9c9930ce1a23634a3e5a8331bf3c7 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
@kumaraditya303 @miss-islington
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
d771639 
…up (pythonGH-94298)

(cherry picked from commit 01ef1f9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 28, 2022

GH-94365 is a backport of this pull request to the 3.11 branch.

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 28, 2022
@kumaraditya303 kumaraditya303 deleted the memleak-pickle branch Jun 28, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jun 28, 2022
@kumaraditya303
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
ccaa5ea 
…up (pythonGH-94298)
@bedevere-bot
Copy link

bedevere-bot commented Jun 28, 2022

GH-94385 is a backport of this pull request to the 3.10 branch.

pablogsal pushed a commit that referenced this pull request Jun 28, 2022
@kumaraditya303
[3.10] GH-89988: Fix memory leak in pickle.Pickler dispatch_table loo…
079ea44 
…kup (GH-94298) (#94385)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@kumaraditya303 @gvanrossum
pythonGH-89988: Fix memory leak in pickle.Pickler dispatch_table look…
8699848 
…up (pythonGH-94298)
miss-islington added a commit that referenced this pull request Jul 14, 2022
@miss-islington @kumaraditya303
GH-89988: Fix memory leak in pickle.Pickler dispatch_table lookup (GH…
91f7914 
…-94298)

(cherry picked from commit 01ef1f9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@erlend-aasland erlend-aasland

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @miss-islington @bedevere-bot @serhiy-storchaka