setup.py only reports successful builds if one or more stdlib modules are missing #93692

erlend-aasland · 2022-06-10T18:35:42Z

"Python build finished successfully!" is only printed if there were missing modules:

Lines 539 to 547 in cf730b5

    
           if self.missing: 
        
               print() 
        
               print("Python build finished successfully!") 
        
               print("The necessary bits to build these optional modules were not " 
        
                     "found:") 
        
               print_three_column(self.missing) 
        
               print("To find the necessary bits, look in setup.py in" 
        
                     " detect_modules() for the module's name.") 
        
               print()

Either we print it every time the build succeeds:

diff --git a/setup.py b/setup.py
index 4c497346e8..e87da57a47 100644
--- a/setup.py
+++ b/setup.py
@@ -538,5 +538,9 @@ def print_three_column(lst):
 
-        if self.missing:
+        if not self.failed:
             print()
             print("Python build finished successfully!")
+            print()
+
+        if self.missing:
+            print()
             print("The necessary bits to build these optional modules were not "

Or we just remove that line from setup.py.

I'm fine with either.

Originally reported by @izumiberat in #93659 (comment)

The text was updated successfully, but these errors were encountered:

erlend-aasland · 2022-06-10T18:36:00Z

cc. @tiran

erlend-aasland · 2022-06-10T18:37:13Z

Come to think of it, we might want to adjust the "To find the necessary bits, look in setup.py in detect_modules() for the module's name." also.

…ucceeded

…93693) The message was only emitted when the build succeeded _and_ there were missing modules.

…up.py (pythonGH-93693) The message was only emitted when the build succeeded _and_ there were missing modules. (cherry picked from commit ab077d1) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

…H-93693) The message was only emitted when the build succeeded _and_ there were missing modules. (cherry picked from commit ab077d1) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 10, 2022

pythongh-93692: setup.py now reports successful builds if the build s…

d9303c4

…ucceeded

erlend-aasland mentioned this issue Jun 10, 2022

gh-93692: remove redundant "build finished successfully" message from setup.py #93693

Merged

AA-Turner added type-bug build 3.12 labels Jun 10, 2022

erlend-aasland closed this as completed in #93693 Jun 24, 2022

erlend-aasland added a commit that referenced this issue Jun 24, 2022

gh-93692: remove "build finished successfully" message from setup.py (#…

ab077d1

…93693) The message was only emitted when the build succeeded _and_ there were missing modules.

bedevere-bot mentioned this issue Jun 24, 2022

[3.10] gh-93692: remove "build finished successfully" message from setup.py (GH-93693) #94209

Merged

bedevere-bot mentioned this issue Jun 24, 2022

[3.11] gh-93692: remove "build finished successfully" message from setup.py (GH-93693) #94210

Merged

setup.py only reports successful builds if one or more stdlib modules are missing #93692

setup.py only reports successful builds if one or more stdlib modules are missing #93692

erlend-aasland commented Jun 10, 2022

erlend-aasland commented Jun 10, 2022

erlend-aasland commented Jun 10, 2022

setup.py only reports successful builds if one or more stdlib modules are missing #93692

setup.py only reports successful builds if one or more stdlib modules are missing #93692

Comments

erlend-aasland commented Jun 10, 2022

erlend-aasland commented Jun 10, 2022

erlend-aasland commented Jun 10, 2022