Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim #100541

Merged
merged 1 commit into from Dec 29, 2022
Merged

gh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim #100541

merged 1 commit into from Dec 29, 2022

Conversation

zware
Copy link
Member

@zware zware commented Dec 26, 2022 •
edited by bedevere-bot

As far as I can tell, this hasn't been actually used since Mac OS X 10.2.

@zware zware requested a review from a team as a code owner Dec 26, 2022
@zware zware added 3.12 OS-mac build The build process and cross-build expert-ctypes extension-modules C modules in the Modules dir labels Dec 26, 2022
@zware zware self-assigned this Dec 26, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 26, 2022
Open
@zware
Copy link
Member Author

zware commented Dec 26, 2022 •
edited

!buildbot macos

@bedevere-bot
Copy link

bedevere-bot commented Dec 26, 2022

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: macOS

The builders matched are:

@zware
Copy link
Member Author

zware commented Dec 26, 2022

!buildbot .*mac

@bedevere-bot
Copy link

bedevere-bot commented Dec 26, 2022

🤖 New build scheduled with the buildbot fleet by @zware for commit 67d159c 🤖

The command will test the builders whose names match following regular expression: .*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zware zware requested a review from a team Dec 26, 2022
@arhadthedev
Copy link
Contributor

arhadthedev commented Dec 27, 2022

Probably, this should be removed too:

cpython/Tools/c-analyzer/cpython/_parser.py

Line 54 in 199507b

#Modules/_ctypes/darwin/*.c

@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from 67d159c to 73b501e Compare Dec 27, 2022
@zware
Copy link
Member Author

zware commented Dec 27, 2022

Probably, this should be removed too:

Ah, thanks; I missed that one here, though I got the neighboring one in GH-100543.

@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from 73b501e to b2b2802 Compare Dec 28, 2022
@zware
pythongh-100540: Remove obsolete Modules/_ctypes/darwin/ dlfcn shim
2404f50 
As far as I can tell, this hasn't been actually used since Mac OS X 10.2.
@zware zware force-pushed the remove__ctypes_dlfcn_shim branch from b2b2802 to 2404f50 Compare Dec 28, 2022
ronaldoussoren
ronaldoussoren approved these changes Dec 29, 2022
View changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Patch looks good to me.

@zware zware merged commit 2df82db into python:main Dec 29, 2022
16 of 17 checks passed
@zware zware deleted the remove__ctypes_dlfcn_shim branch Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren

@python/windows-team windows-team

Assignees

@zware zware

Labels
3.12 build The build process and cross-build expert-ctypes extension-modules C modules in the Modules dir OS-mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zware @bedevere-bot @arhadthedev @ronaldoussoren