Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45359: Support TopologicalSorter type subscript #28714

Merged
merged 4 commits into from Dec 8, 2021
Merged

bpo-45359: Support TopologicalSorter type subscript #28714

merged 4 commits into from Dec 8, 2021

Conversation

JacobHayes
Copy link
Contributor

@JacobHayes JacobHayes commented Oct 3, 2021 •
edited by miss-islington

Add TopologicalSorter.__class_getitem__ = classmethod(GenericAlias) to support runtime subscription.

https://bugs.python.org/issue45359

Automerge-Triggered-By: GH:isidentical

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 3, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JacobHayes

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

We also demand... A SHRUBBERY!

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JacobHayes JacobHayes mentioned this pull request Oct 3, 2021
Closed
@JacobHayes
Copy link
Contributor Author

JacobHayes commented Oct 3, 2021

FYI: CLA has been signed, pending acceptance.

@corona10 corona10 requested review from pablogsal and rhettinger Oct 4, 2021
isidentical
isidentical reviewed Oct 16, 2021
View changes
Copy link
Sponsor Member

@isidentical isidentical left a comment

This LGTM. The only missing thing is a test at https://github.com/python/cpython/blob/main/Lib/test/test_genericalias.py

@JacobHayes
Copy link
Contributor Author

JacobHayes commented Nov 2, 2021

I think this is ready for another look when folks have time. Thanks!

@AlexWaygood AlexWaygood requested a review from isidentical Dec 8, 2021
@isidentical isidentical added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 8, 2021
@asvetlov asvetlov merged commit 3cb9731 into python:main Dec 8, 2021
12 checks passed
@JacobHayes JacobHayes deleted the TopologicalSorter-class-getitem branch Jan 3, 2022
@AlexWaygood AlexWaygood mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical

@AlexWaygood AlexWaygood

@pablogsal pablogsal

@rhettinger rhettinger

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JacobHayes @the-knights-who-say-ni @isidentical @AlexWaygood @asvetlov @bedevere-bot