gh-93626: Set the release for `future.annotations` to `None` #93628

KotlinIsland · 2022-06-09T05:11:40Z

Hi everyone, I noticed that __future__.annotations was turned on in the 3.11 betas 😳😳😳😳😳😳.

This is highly sus as it should be turned off till further notice ~~(3.12 )~~ (None kinda means 'tbd' I think).

This is my first cpython contrib, I tried to follow the contributing process, but maybe I missed something, sorry!

This PR also needs to be backported to the 3.11 branch

resolves: #93626

Issue: __future__.annotations has inaccurate mandatoryRelease value #93626

Corresponding typeshed PR python/typeshed#8232

cpython-cla-bot · 2022-06-09T05:11:41Z

All commit authors signed the Contributor License Agreement.

KotlinIsland · 2022-06-09T05:15:57Z

I think your CLA facility is busted, when I sign it, it just says:

Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: kotlinisland@users.noreply.github.com.

KotlinIsland · 2022-06-19T06:48:09Z

@pablogsal I've changed the mandatory release to None to reflect that the release version is 'tbd'

ambv · 2022-06-20T12:12:45Z

@KotlinIsland can you try signing the CLA again?

KotlinIsland · 2022-06-20T13:53:58Z

@ambv

Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: kotlinisland@users.noreply.github.com,65446343+KotlinIsland@users.noreply.github.com.

ambv · 2022-06-20T14:27:58Z

@KotlinIsland please try again.

KotlinIsland · 2022-06-21T01:13:39Z

@ambv it worked 😳.
Thanks 😁

KotlinIsland · 2022-06-29T23:45:32Z

@graingert This needs to be backported to 3.11

KotlinIsland · 2022-06-29T23:46:33Z

@pablogsal This is a critical release blocker for 3.11

DetachHead

LGTM 🚀🚀🚀

JelleZijlstra · 2022-06-29T23:58:21Z

Doc/whatsnew/3.11.rst

@@ -377,6 +377,10 @@ Other Language Changes
  coerces negative zero to zero after rounding to the format precision.  See
  :pep:`682` for more details.  (Contributed by John Belmonte in :gh:`90153`.)

+* :pep:`563` Postponed Evaluation of Annotations, ``__future__.annotations`` has been indefinitely postponed.


I don't think this fits here as there's no change.

Personally I rushed to the release page to see the status of pep 563 as in 3.10 it was marked as being released in 3.11. And was surprised to see that there was no mention of it, despite the fact that it has been pulled from 3.11.

I hadn't seen any of the information regarding it's changed status, it would be of value to be to have it in here. Maybe it could be moved to a different section of the release notes? or maybe the full-form changelog?

Perhaps in the "Improved Modules" section it could be listed under __future__?

I would suggest something along the lines of a "Non-futures Related to Type Hints" subsection of the "New Features Related to Type Hints" section above. Maybe not that particular name, but I enjoyed coming up with it :)

Lines in our reST docs should be wrapped at 80 columns as noted in the devguide.

Done, I used your suggested name because I didn't understand what you meant by it😁

Misc/NEWS.d/next/Library/2022-06-09-14-44-21.gh-issue-93626.amongus.rst

zware · 2022-06-30T02:39:11Z

Doc/whatsnew/3.11.rst

@@ -377,6 +377,10 @@ Other Language Changes
  coerces negative zero to zero after rounding to the format precision.  See
  :pep:`682` for more details.  (Contributed by John Belmonte in :gh:`90153`.)

+* :pep:`563` Postponed Evaluation of Annotations, ``__future__.annotations`` has been indefinitely postponed.


I would suggest something along the lines of a "Non-futures Related to Type Hints" subsection of the "New Features Related to Type Hints" section above. Maybe not that particular name, but I enjoyed coming up with it :)

Lines in our reST docs should be wrapped at 80 columns as noted in the devguide.

Lib/__future__.py

Misc/NEWS.d/next/Library/2022-06-09-14-44-21.gh-issue-93626.amongus.rst

bedevere-bot · 2022-06-30T02:39:16Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Lib/__future__.py

gvanrossum

Two nits (tweaking the section heading, and keeping the long url on one line), otherwise LGTM.

Doc/whatsnew/3.11.rst

Changes made, chance to re-review not currently available

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

miss-islington · 2022-07-05T08:46:42Z

Thanks @KotlinIsland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛄1�7🤖

bedevere-bot · 2022-07-05T08:46:58Z

GH-94553 is a backport of this pull request to the 3.11 branch.

pythonGH-93628) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> (cherry picked from commit 4791a8a) Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>

graingert · 2022-07-05T08:47:32Z

does this make sense backported to 3.10?

ambv · 2022-07-05T08:48:36Z

There is no 3.11 whatsnew in 3.10 and it seems to me that the clarified meaning of None shouldn't be used mid-release cycle.

1�793628) (GH-94553) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> (cherry picked from commit 4791a8a) Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>

bedevere-bot added the awaiting review label Jun 9, 2022

Fidget-Spinner requested a review from pablogsal Jun 9, 2022

arhadthedev mentioned this pull request Jun 19, 2022

CLA bot reports HTTP 500: Internal Server Error edgedb/cla-bot#50

Closed

KotlinIsland changed the title ~~gh-93626: Set the release for __future__.annotations to 3.12~~ gh-93626: Set the release for __future__.annotations to None Jun 21, 2022

KotlinIsland force-pushed the patch-1 branch 2 times, most recently from 1927446 to 0b37fba Compare Jun 21, 2022

ambv mentioned this pull request Jun 21, 2022

Make username CLA checks case insignificant edgedb/cla-bot#52

Merged

graingert approved these changes Jun 29, 2022

View changes

bedevere-bot added awaiting core review and removed awaiting review labels Jun 29, 2022

DetachHead approved these changes Jun 29, 2022

View changes

JelleZijlstra reviewed Jun 29, 2022

View changes

KotlinIsland mentioned this pull request Jun 30, 2022

__future__.annotations has inaccurate mandatoryRelease value #93626

Closed

graingert requested changes Jun 30, 2022

View changes

Misc/NEWS.d/next/Library/2022-06-09-14-44-21.gh-issue-93626.amongus.rst Outdated Show resolved Hide resolved

zware previously requested changes Jun 30, 2022

View changes

bedevere-bot added awaiting changes and removed awaiting core review labels Jun 30, 2022

KotlinIsland force-pushed the patch-1 branch from 0b37fba to 75582a6 Compare Jul 1, 2022

KotlinIsland requested a review from zware Jul 1, 2022

KotlinIsland force-pushed the patch-1 branch from 75582a6 to f6a92cc Compare Jul 3, 2022

KotlinIsland force-pushed the patch-1 branch from f6a92cc to f14810c Compare Jul 3, 2022

KotlinIsland mentioned this pull request Jul 3, 2022

(🐞) __future__._Feature.getMandatoryRelease should be Optional python/typeshed#8232

Merged

graingert reviewed Jul 3, 2022

View changes

Lib/__future__.py Outdated Show resolved Hide resolved

pythongh-93626: Set the release for __future__.annotations to None

fd66e10

KotlinIsland force-pushed the patch-1 branch from f14810c to fd66e10 Compare Jul 3, 2022

gvanrossum reviewed Jul 4, 2022

View changes

Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved

Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved

KotlinIsland and others added 2 commits Jul 5, 2022

Update whatsnew

6e0a02d

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

Update whatsnew

997df43

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

ambv added the needs backport to 3.11 label Jul 5, 2022

ambv merged commit 4791a8a into python:main Jul 5, 2022
14 checks passed

bedevere-bot removed awaiting changes needs backport to 3.11 labels Jul 5, 2022

KotlinIsland deleted the patch-1 branch Jul 5, 2022

KotlinIsland mentioned this pull request Sep 13, 2022

Add language level for Python 3.12 JetBrains/intellij-community#2037

Closed

andersk mentioned this pull request Oct 4, 2022

Automatically remove quoted annotations charliermarsh/ruff#314

Open

gh-93626: Set the release for `future.annotations` to `None` #93628

gh-93626: Set the release for `future.annotations` to `None` #93628

KotlinIsland commented Jun 9, 2022 •

edited

cpython-cla-bot bot commented Jun 9, 2022 •

edited

KotlinIsland commented Jun 9, 2022

KotlinIsland commented Jun 19, 2022

ambv commented Jun 20, 2022

KotlinIsland commented Jun 20, 2022 •

edited

ambv commented Jun 20, 2022

KotlinIsland commented Jun 21, 2022

KotlinIsland commented Jun 29, 2022

KotlinIsland commented Jun 29, 2022

DetachHead left a comment

JelleZijlstra Jun 29, 2022

KotlinIsland Jun 30, 2022 •

edited

KotlinIsland Jun 30, 2022

zware Jun 30, 2022

KotlinIsland Jul 1, 2022

zware Jun 30, 2022

bedevere-bot commented Jun 30, 2022

gvanrossum left a comment

miss-islington commented Jul 5, 2022

bedevere-bot commented Jul 5, 2022

graingert commented Jul 5, 2022

ambv commented Jul 5, 2022

gh-93626: Set the release for __future__.annotations to None #93628

gh-93626: Set the release for __future__.annotations to None #93628

Conversation

KotlinIsland commented Jun 9, 2022 • edited

cpython-cla-bot bot commented Jun 9, 2022 • edited

KotlinIsland commented Jun 9, 2022

KotlinIsland commented Jun 19, 2022

ambv commented Jun 20, 2022

KotlinIsland commented Jun 20, 2022 • edited

ambv commented Jun 20, 2022

KotlinIsland commented Jun 21, 2022

KotlinIsland commented Jun 29, 2022

KotlinIsland commented Jun 29, 2022

DetachHead left a comment

JelleZijlstra Jun 29, 2022

Choose a reason for hiding this comment

KotlinIsland Jun 30, 2022 • edited

Choose a reason for hiding this comment

KotlinIsland Jun 30, 2022

Choose a reason for hiding this comment

zware Jun 30, 2022

Choose a reason for hiding this comment

KotlinIsland Jul 1, 2022

Choose a reason for hiding this comment

zware Jun 30, 2022

Choose a reason for hiding this comment

bedevere-bot commented Jun 30, 2022

gvanrossum left a comment

miss-islington commented Jul 5, 2022

bedevere-bot commented Jul 5, 2022

graingert commented Jul 5, 2022

ambv commented Jul 5, 2022

gh-93626: Set the release for `future.annotations` to `None` #93628

gh-93626: Set the release for `future.annotations` to `None` #93628

KotlinIsland commented Jun 9, 2022 •

edited

cpython-cla-bot bot commented Jun 9, 2022 •

edited

KotlinIsland commented Jun 20, 2022 •

edited

KotlinIsland Jun 30, 2022 •

edited