Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92546: Move pprint benchmark into pyperformance #94613

Merged
merged 4 commits into from Jul 25, 2022
Merged

gh-92546: Move pprint benchmark into pyperformance #94613

merged 4 commits into from Jul 25, 2022

Conversation

arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Jul 6, 2022 •
edited by miss-islington

This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment).

Automerge-Triggered-By: GH:ericsnowcurrently

@arhadthedev arhadthedev mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 6, 2022
Merged
Open
@kj7rrv kj7rrv mentioned this pull request Jul 6, 2022
Closed
hauntsaninja
hauntsaninja approved these changes Jul 8, 2022
View changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Had a nit, but looks good!

Misc/NEWS.d/next/Library/2022-07-06-21-24-03.gh-issue-92546.s5Upkh.rst Outdated Show resolved Hide resolved
@arhadthedev @hauntsaninja
Address Shantanu's review
f7bc339 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@arhadthedev arhadthedev closed this Jul 8, 2022
@arhadthedev arhadthedev reopened this Jul 8, 2022
@arhadthedev
Copy link
Contributor Author

arhadthedev commented Jul 8, 2022

Restart tests because test.test_ssl.SimpleBackgroundTests.test_get_server_certificate_timeout timeout failure seems unrelated.

@arhadthedev
Copy link
Contributor Author

arhadthedev commented Jul 24, 2022

@ericsnowcurrently Could you look at this PR please? It removes the code fetched by python/pyperformance#222.

ericsnowcurrently
ericsnowcurrently approved these changes Jul 25, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM, aside from one small change.

Misc/NEWS.d/next/Library/2022-07-06-21-24-03.gh-issue-92546.s5Upkh.rst Outdated Show resolved Hide resolved
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 25, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jul 25, 2022

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c514094 into python:main Jul 25, 2022
14 checks passed
@arhadthedev arhadthedev deleted the move-pprint-benchmark branch Jul 25, 2022
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Jul 26, 2022

Thanks for working on this, @arhadthedev!

@denballakh denballakh mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

@hauntsaninja hauntsaninja

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arhadthedev @miss-islington @ericsnowcurrently @hauntsaninja @bedevere-bot