New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95273: Improve sqlite3.complete_statement docs #95840
gh-95273: Improve sqlite3.complete_statement docs #95840
Conversation
erlend-aasland
commented
Aug 9, 2022
•
edited by bedevere-bot
edited by bedevere-bot
- Issue: Improve the sqlite3 reference #95273
Thanks for the review, CAM; PTAL before I land this. |
LGTM otherwise, but I definitely think that the minimal example @ezio-melotti suggested would be very helpful to add here. I've made it as a suggestion.
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Review comments addressed. I also relocated the example; I felt it made more sense to have it just after the first paragraph. |
Thanks for the reviews! Now I'll fix |
Thanks @erlend-aasland for the PR |
Sorry, @erlend-aasland, I could not cleanly backport this to |
Sorry @erlend-aasland, I had trouble checking out the |
I'll fix the backports tomorrow. |
…nGH-95840) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-95917 is a backport of this pull request to the 3.11 branch. |
…nGH-95840) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-95918 is a backport of this pull request to the 3.10 branch. |