Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99341: Cover type ignore nodes when incrementing line numbers #99422

Merged
merged 2 commits into from Nov 22, 2022
Merged

gh-99341: Cover type ignore nodes when incrementing line numbers #99422

merged 2 commits into from Nov 22, 2022
+20 −0

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Nov 12, 2022 •
edited by miss-islington

@bedevere-bot bedevere-bot mentioned this pull request Nov 12, 2022
Closed
@isidentical isidentical marked this pull request as ready for review Nov 21, 2022
@isidentical isidentical requested a review from pablogsal Nov 21, 2022
@isidentical isidentical added needs backport to 3.10 needs backport to 3.11 🤖 automerge PR will be merged once it's been approved and all CI passed labels Nov 22, 2022
@miss-islington miss-islington merged commit 1acdfec into python:main Nov 22, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 22, 2022

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2022
@isidentical @miss-islington
pythongh-99341: Cover type ignore nodes when incrementing line numbers (
60ffd1c 
pythonGH-99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 22, 2022

GH-99683 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2022
@isidentical @miss-islington
pythongh-99341: Cover type ignore nodes when incrementing line numbers (
e2f07ba 
pythonGH-99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 22, 2022

GH-99684 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Nov 22, 2022
@miss-islington @isidentical
gh-99341: Cover type ignore nodes when incrementing line numbers (GH-…
85dbd2d 
…99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
miss-islington added a commit that referenced this pull request Nov 22, 2022
@miss-islington @isidentical
gh-99341: Cover type ignore nodes when incrementing line numbers (GH-…
99e852c 
…99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@isidentical @miss-islington @bedevere-bot @pablogsal