[ExpressionLanguage] Add enum expression function
#48669
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandre-daubois
commented
Dec 15, 2022
•
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #48593 |
| License | MIT |
| Doc PR | symfony/symfony-docs#17632 |
alexandre-daubois
force-pushed
the
feat/enum-expression-language
branch
5 times, most recently
from
63e5a9a
to
3437438
Compare
|
Hey! I think @mytuny has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
OskarStark
reviewed
Dec 18, 2022
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
feat/enum-expression-language
branch
from
3437438
to
db92423
Compare
OskarStark
approved these changes
Dec 19, 2022
nicolas-grekas
requested changes
Dec 22, 2022
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
feat/enum-expression-language
branch
from
db92423
to
bda8415
Compare
stof
reviewed
Dec 23, 2022
src/Symfony/Component/ExpressionLanguage/ExpressionLanguage.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
reviewed
Dec 23, 2022
src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
feat/enum-expression-language
branch
from
bda8415
to
0223cea
Compare
nicolas-grekas
approved these changes
Dec 29, 2022
| @@ -138,6 +138,19 @@ public function registerProvider(ExpressionFunctionProviderInterface $provider) | |||
| protected function registerFunctions() | |||
| { | |||
| $this->addFunction(ExpressionFunction::fromPhp('constant')); | |||
|
|
|||
| $this->addFunction(new ExpressionFunction('enum', | |||
| static fn ($str): string => sprintf("(\constant(\$v = (%1\$s))) instanceof \UnitEnum ? \constant(\$v) : throw new \TypeError(\sprintf('The string \"%%s\" is not the name of a valid enum case.', \$v))", $str), | |||
There was a problem hiding this comment.
Can be just %s instead of %1$s
There was a problem hiding this comment.
Thank you!
alexandre-daubois
force-pushed
the
feat/enum-expression-language
branch
from
0223cea
to
53bfee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.