Fix incorrect method in doc #24824

oscargus · 2022-12-27T10:50:52Z

PR Summary

cleanup is removed (never existed? cannot find when it was removed...).

Not sure that the edited comment is actually true, but at least it is no longer obviously incorrect.

Documentation and Tests

Has pytest style unit tests (and pytest passes)
Documentation is sphinx and numpydoc compliant (the docs should build without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

dstansby · 2022-12-27T19:10:27Z

Isn't this comment talking about the cleanup() method on tempfile.TemporaryDirectory?

oscargus · 2022-12-28T01:15:51Z

I found the PR. Turns out thar I missed updating those things... #22365

Fix incorrect method in doc

212848a

oscargus added Documentation topic: animation labels Dec 27, 2022

dstansby approved these changes Dec 28, 2022

View reviewed changes

QuLogic approved these changes Dec 29, 2022

View reviewed changes

QuLogic merged commit 8b7c3b4 into matplotlib:main Dec 29, 2022

QuLogic added this to the v3.7.0 milestone Dec 29, 2022

oscargus deleted the animationcleanup branch December 29, 2022 01:50