New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add from __future__ import annotations
in even more files; remove more quotes from annotations
#13412
Conversation
from __future__ import annotations
in even more files; remove more quoted annotationsfrom __future__ import annotations
in even more files; remove more quotes from annotations
This comment has been minimized.
This comment has been minimized.
1 similar comment
According to mypy_primer, this change has no effect on the checked open source code. |
Looks good AFAICT! Thanks for the follow up @AlexWaygood.
I left two small comments where I think a trailing comma could be useful.
Thanks for the review @cdce8p!
I tried adding these, but black just strips them away again ;) |
Found the issue Line 11 in f8fc26e
The magic-trailing-comma isn't perfect but IMO it works well enough. I would recommend to remove that setting. |
Good catch! I think it was @hauntsaninja that recommended enabling that setting in the initial refactor-for-black PR. Whatever the wisdom of that setting, however, I'm not going to change that in this PR, since it's slightly tangential to this PR's purpose :-) |
I don't like the magic trailing comma and I would not like that setting changed. |
It might not be perfect but what I like about it is it at least gives you the option to choose a better formatting if it makes sense. I opened #13418 to show the impact of removing the option. |
#13391 and #13407 missed a few spots ;)
Cc. @jhance / @cdce8p