gh-100488: Add is_integer method to fractions.Fraction #100489
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation guarantees that denominator is in lowest term. It doesn't make any explicit guarantee about being positive, but |
mdickinson
approved these changes
Dec 29, 2022
| @@ -117,6 +117,12 @@ another rational number, or from a string. | |||
|
|
|||
| .. versionadded:: 3.8 | |||
|
|
|||
| .. method:: is_integer() | |||
|
|
|||
| Return True if the Fraction is an integer. | |||
There was a problem hiding this comment.
Nitpick: suggest inline code markup for True:
Suggested change
| Return True if the Fraction is an integer. | |
| Return ``True`` if the Fraction is an integer. |
(We seem to be rather inconsistent about this across the codebase. The most authoritative source I could find is in the dev guide: https://devguide.python.org/documentation/markup/#quick-reference.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
is_integerto fractions.Fraction #100488