New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-78878: Fix crash when creating an instance of _ctypes.CField
#14837
Conversation
@serhiy-storchaka @izbyshev Hi, guys. I have try to solve this probleam, pls review this patch, thank you :) |
@shihai1991 Can you fix the conflicts ? Thanks |
Of course. Thanks for your review. I forget detail already. I will take a look again. |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
* origin/main: (1306 commits) Correct CVE-2020-10735 documentation (python#100306) pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273) pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551) Docs: Use `PY_VERSION_HEX` for version comparison (python#100179) pythongh-97909: Fix markup for `PyMethodDef` members (python#100089) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205) pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469) pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541) pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168) pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302) "Compound statement" docs: Fix with-statement step indexing (python#100286) pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278) Improve stats presentation for calls. (pythonGH-100274) Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295) pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277) Document that zipfile's pwd parameter is a `bytes` object (python#100209) pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271) Fix typo in introduction.rst (python#100266) ...
Resolve the conflict again :) |
I have made the requested changes; please review again |
Thanks for making the requested changes! @iritkatriel: please review the changes made to this pull request. |
_ctypes.CField
Misc/NEWS.d/next/Core and Builtins/2022-12-18-19-07-29.gh-issue-78878.00QOp1.rst
Outdated
Show resolved
Hide resolved
Thanks @shihai1991 for the PR, and @kumaraditya303 for merging it |
Sorry, @shihai1991 and @kumaraditya303, I could not cleanly backport this to |
GH-100413 is a backport of this pull request to the 3.11 branch. |
…d` (pythonGH-14837) (cherry picked from commit d713c54) Co-authored-by: Hai Shi <shihai1992@gmail.com>
Let's only backport to 3.11. |
|
It's an very old MR. Thanks everyone's review. Thanks Kumar for your merge. |
https://bugs.python.org/issue34697