Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94155: Reduce hash collisions for code objects #100183

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Dec 12, 2022

  • Uses a better hashing algorithm to get better dispersion and remove commutativity.
  • Incorporates co_firstlineno, Py_SIZE(co), and bytecode instructions.
    • This is now the entire set of criteria used in code_richcompare, except for _PyCode_ConstantKey, which incorporates the types of co_consts rather than just their values.

@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit dbb5c77
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6396af9c8f8ab9000802fbe9
😎 Deploy Preview https://deploy-preview-100183--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sweeneyde sweeneyde marked this pull request as ready for review Dec 12, 2022
@sweeneyde sweeneyde requested a review from markshannon as a code owner Dec 12, 2022
@sweeneyde sweeneyde requested a review from larryhastings Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants