Skip to content

GH-86508: skip binding to local addresses of different family in asyncio.open_connection #100615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2023
Merged

GH-86508: skip binding to local addresses of different family in asyncio.open_connection #100615

merged 4 commits into from
Jan 4, 2023

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 30, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Dec 30, 2022
Closed
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes labels Dec 30, 2022
@kumaraditya303 kumaraditya303 linked an issue Dec 30, 2022 that may be closed by this pull request
asyncio.open_connection(local_addr=('localhost', port)) fails with TypeError: AF_INET address must be a pair (host, port) #86508
Closed
gvanrossum
gvanrossum approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, go for it!

@kumaraditya303 kumaraditya303 merged commit ba8dcdb into python:main Jan 4, 2023
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the fix-addr branch January 4, 2023 08:00
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
@kumaraditya303 @miss-islington
pythonGH-86508: skip binding to local addresses of different family i…
7a1bbfa 
…n `asyncio.open_connection` (pythonGH-100615)

(cherry picked from commit ba8dcdb)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-100741 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
@kumaraditya303 @miss-islington
pythonGH-86508: skip binding to local addresses of different family i…
c7aef68 
…n `asyncio.open_connection` (pythonGH-100615)

(cherry picked from commit ba8dcdb)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-100742 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 4, 2023
miss-islington added a commit that referenced this pull request Jan 4, 2023
@miss-islington @kumaraditya303
GH-86508: skip binding to local addresses of different family in `asy…
35a010f 
…ncio.open_connection` (GH-100615)

(cherry picked from commit ba8dcdb)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 4, 2023
@miss-islington @kumaraditya303
GH-86508: skip binding to local addresses of different family in `asy…
ad40764 
…ncio.open_connection` (GH-100615)

(cherry picked from commit ba8dcdb)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
3.10 only security fixes 3.11 only security fixes 3.12 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
4 participants
@kumaraditya303 @miss-islington @bedevere-bot @gvanrossum