[mypyc] Support attributes that override properties #14377
+487
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
commented
Jan 2, 2023
| @@ -223,8 +236,68 @@ def prepare_class_def( | |||
| # Supports copy.copy and pickle (including subclasses) | |||
| ir._serializable = True | |||
|
|
|||
| # We sort the table for determinism here on Python 3.5 | |||
| for name, node in sorted(info.names.items()): | |||
| # Check for subclassing from builtin types | |||
There was a problem hiding this comment.
I had to restructure this to do things in a different order. Most of the logic hasn't changed. I also extracted some functionality to separate methods since the function was already quite big.
|
According to mypy_primer, this change has no effect on the checked open source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Code like this is now supported by mypyc:
The implementation generates implicit getter/setter methods for attributes as needed and puts them in the vtable. I had to change both the irbuild "prepare" pass (where we generate declarations), irbuild main pass (where we generate implicit accessor IRs), and codegen (where implicit properties aren't visible externally to CPython).
Also fix a minor mypy bug related to overriding properties and multiple inheritance that I encountered.
This doesn't handle glue methods yet.