gh-99595: Fix bug in multiprocessing.managers.BaseProxy that causes AttributeError when passing a proxy between processes #99598
+67
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing a proxy between processes When a proxy derived from multiprocessing.managers.BaseProxy is passed between processes, the self._manager attribute becomes None. self._manager is however accessed to retrieve its _registry attribute, which contain the method_to_typeid map recorded into the manager viaBaseManager.register(), causing an AttributeError.
…uses AttributeError when passing a proxy between processes Decouple the role of the manager from the role of the registry in the proxy and initialize the proxy with the registry instance separately from the manager instance.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When a proxy derived from
multiprocessing.managers.BaseProxyis passed between processes, theself._managerattribute becomesNone.self._manageris however accessed to retrieve its_registryattribute, which contain themethod_to_typeidmap recorded into the manager viaBaseManager.register(), causing anAttributeError. The solution is to decouple the role of the manager from the role of the registry and propagate the registry separately.