New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests of copy
module
#100871
Comments
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jan 9, 2023
miss-islington
pushed a commit
that referenced
this issue
Jan 11, 2023
CC @AlexWaygood as the reviewer of #100818 Automerge-Triggered-By: GH:AlexWaygood
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jan 12, 2023
CC @AlexWaygood as the reviewer of python#100818 Automerge-Triggered-By: GH:AlexWaygood. (cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jan 12, 2023
CC @AlexWaygood as the reviewer of python#100818 Automerge-Triggered-By: GH:AlexWaygood. (cherry picked from commit 729ab9b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood
pushed a commit
that referenced
this issue
Jan 12, 2023
AlexWaygood
pushed a commit
that referenced
this issue
Jan 12, 2023
Thanks @sobolevn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After working on #100817 I've noticed that there are multiple things that can be improved in terms of
copy
module tests:copy.deepcopy
calls onslice
objects #100818 but, our test cases were not able to detect it. Solution: add a new test case intest_slice.py
withcopy
anddeepcopy
calls. I think it should be intest_slice
and not intest_copy
, because there's nothing special about it:copy
does not change its behaviour or special case it.copyreg
we can now copy an object, but does not assert the result:cpython/Lib/test/test_copy.py
Lines 42 to 55 in e47b139
cpython/Lib/test/test_copy.py
Lines 302 to 315 in e47b139
test_deepcopy_atomic
misses several important types:bytes
,types.EllipsisType
,NotImplementedType
.cpython/Lib/test/test_copy.py
Lines 350 to 359 in e47b139
PR is incoming.
Linked PRs
copy
module tests #100872copy
module tests (GH-100872) #100975copy
module tests (GH-100872) #100976The text was updated successfully, but these errors were encountered: