Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37985: Remove redundant p->depth-- in marshal extension module #19482

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-37985: Remove redundant p->depth-- in marshal extension module #19482

wants to merge 2 commits into from
+0 −4

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Apr 12, 2020 •
edited by bedevere-bot

@shihai1991 shihai1991 requested a review from tiran as a code owner Apr 12, 2020
@shihai1991 shihai1991 changed the title WIP: Remove redundant p->depth-- in marshal extension module bpo-37985: Remove redundant p->depth-- in marshal extension module Apr 12, 2020
@csabella csabella requested a review from serhiy-storchaka Apr 16, 2020
@taleinat
Copy link
Contributor

Ping, @serhiy-storchaka?

@tiran tiran removed their request for review Apr 17, 2021
@opensdh opensdh mannequin mentioned this pull request Jan 12, 2023
Open
@serhiy-storchaka
Copy link
Member

I am not sure whether they are redundant in that sites, or other sites lack them. I think that the whole error handling in the marshal module should be reworked, because currently it is possible to mask some other errors with the "object too deeply nested" error, and this change will make it worse. And I do not know what a crash the original report refers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@shihai1991 @taleinat @serhiy-storchaka @corona10 @the-knights-who-say-ni @ezio-melotti @bedevere-bot @kumaraditya303